Skip to content
Submitted about 3 years ago

Trying to solve Profile card component

mandresy andri•90
@mandresyandri
A solution to the Profile card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hello world ! 😎

I tried my best, do not hesitate if you've any advice. 😉

Have a nice sunday !

Code
Couldn’t fetch repository

Please log in to post a comment

Log in

Community feedback

  • Vanza Setia•27,715
    @vanzasetia

    Hi there! 👋

    Congratulations on completing this challenge! 🎉

    I notice there is <ddiv> tag in the HTML. I am pretty sure that you mean div, right?

    Some more suggestions.

    • There should not be text in span and div alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.
    • For the statistic, I recommend using a list element.
    • The attribution should live outside the main landmark. It should live inside the footer landmark.
    • Never limit the height of the body element. It will not allow the users to scroll the page if the page content needs more height. You can see the issue by looking at the site on a mobile landscape view. So, my recommendation is to use min-height instead.

    That's it! I hope this helps!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord