Url shortening app using react

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img class="statistics__gridImage" src="icon-detailed-records.svg" alt="icon">
  👇
  <img class="statistics__gridImage" src="icon-detailed-records.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00

  Marked as helpful
• 

  Azizbek Yunusaliev•400

  @azick99

  Posted about 2 years ago

  Hi! I really like your project and I see you did a lot. If you don't mind I will give you some feedbacks to improve your web app.

  • Work with responsiveness in smaller screens images and words overlapping. So, it looks like not good, I think you got larger screen in your PC but in mine it has bad layouts.

  • Input Link my advice instead link.length === 0 , it's better to create new useState and make it status state like changing status when you click button setStatus('empty') if input empty and setStatus('typing') when you typing. To better understand you can checkout my solution I made it in Features Section.

  • When you refresh the page it does not save the changes like links that is posted. But in the challenge it is required, to make it save you can use local storage. Try to find more information about local storage better choice ask for it in chatGPT.

  I hope it would be useful for you!

  00

  Marked as helpful