use react for filtering list and react router dom also design in css

Community feedback

• 

  Felipe Stefani•330

  @felipestefani

  Posted almost 2 years ago

  Despite the css gap, the project get very nice!

  All the logic seems to be perfect and the classes are bind dynamically, as I could see.

  I don’t know if you know tailwind or bootstrap, but it helps a lot with the style.

  I’kk let the links here to check it out: tailwind bootstrap

  In my projects I’m coding all css as well, but now it’s my focus. If the idea is to code the project, this tools helps a lot!

  Great job! I liked a lot 😉

  02

  Marked as helpful
• 

  Fazza Razaq Amiarso•2,320

  @fazzaamiarso

  Posted almost 2 years ago

  Hi @sumyta12! Great job on your project!

  I have some quick suggestion for you:

  • It's better to set initial state in useState Initialization, rather than in useEffect.

  const [joblist, setJoblisting] = useState([...Joblistingdata]); // initialize state here ✅
  

  • In your urlParams useEffect, you can refactor it like this:

    for (const [key, searchValue] of Object.entries(displaySearch)) {
        if (Array.isArray(searchValue)) {
          searchValue.forEach((value) => {
            urlParams.append(key, value);
          });
        } else {
          urlParams.set(key, searchValue);
        }
      }
  

  I hope it helps! Cheers!

  01

  Marked as helpful