Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 29 days ago

Used bootstrap as well as custom css to create layout to match design.

bootstrap, sass/scss
P
Dudley Seddon•50
@Dudamania
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm most proud of the way of aligning the modal vertically. Next time I would look at other ways of overcoming this challenge by use of other methods.

What challenges did you encounter, and how did you overcome them?

The main challenge I encountered was vertically centering the div modal container the qr code and content. I overcame this by using position absolute, relative to the direct parent container. then aligning with top, left and transform.

What specific areas of your project would you like help with?

Better methods of vertically centering divs and other sections.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Ed Johnson•170
    @edjohnsondev
    Posted 22 days ago

    Nice work! And good one for using transform to bring it back by 50% of what you moved!

    Couple links to help you with some other methods to do this as with something like this it's a valid solution to use. But as position: absolute; removes the element from the normal flow it'll cause more work with responsiveness as it's essentially no loner in the container you have. It's great if you want to layer things on top of another, like a blog post with a tag for the category and so on.

    Theres a couple other methods i'd suggest.

    display: flex; This allows you to position the element or elements anywhere inside the container. If you've had a look at Bootstrap it's what that uses.

    To centre something inside the container both vertically and horizontally you'd do this

    .container {
      display: flex;
      justify-content: center; /* horizontal centering */
      align-items: center;     /* vertical centering */
    }
    

    Take a look at: Flexbox Froggy. This is a handy tool to pick it up!

    You've also then got display: grid;

    Which turns your container into a two dimensional grid. Settings how many rows/columns as you want and then placing each child element in that cell.

    If all you need is to centre one thing (or line up a simple row/column), flexbox is quicker and easier.

    When your layout is more complex / multiple rows and columns that need to rearrange themselves at different screen sizes. Grid makes it easy to change where things sit when the design “stacks” or shifts on smaller screens.

    Check this out: CSS Grid.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub