Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Used GRID for rating and flex for body

i_d_s_lβ€’ 270

@ilvdrskn

Desktop design screenshot for the Expenses chart component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was my first experience with fetch, considering that I don't even know what promises are. The disadvantage of this work is probably that I hammered the days of the week into the table with my hands, and not through json

Community feedback

P
visualdennisβ€’ 8,295

@visualdenniss

Posted

Hello there,

congrats on completing the challenge successfully! On tablet view, it looks like the chart columns overflow the grid container, due to grid-template-columns: repeat(7, 50px); i'd suggest replacing it with grid-template-columns: repeat(7, 1fr); and adding some gap using gap: 5px etc. and also add some max-width to the grid container itself if necessary at all. This way the grid will be more consistent and flexible.

Hope you find this feedback helpful!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord