@Samadeen
Posted
Hey Woodrow!! Cheers 🥂 on completing this challenge.. .
Lets firstly work on your accessibility issues.
Document should have on main landmark
basically means your html should be structured more semantically and the correct format should be your<header>......</header>
followed by your<main>......</main>
and lastly your<footer>....</footer>
hence you should use<main class="card">
instead of<div class="card">
.- Your
footer
should be<footer class="attribution">
instead of<div =attribution>
Images must have alternate text
- Its hard for screen readers to pick up messages from images withoutalt
text.. Its always advisable to includealt
text to aid screen reader
This should fix most of your accessibility issues.
- For your design here is a tip to center your container both vertically and horizontally
display: grid;
place-content: center;
min-height: 100vh;
. Regardless you did amazing... hope you find this helpful... Happy coding!!!
Marked as helpful
@wmartyr
Posted
@Samadeen Hi Abdul, Thank you for your tips. I would keep that in mind starting now. Cheers.