Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Used position and a little flexbox

Alexei 831

@Batareika007

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


If there any suggestion to write CSS more friendly I would like to hear =)

Community feedback

Arturo Simon 1,785

@artimys

Posted

Nice job Alexei, the card looks very similar to the original.

Some feedback:

  • To help get a more clean/consistent naming pattern to your CSS components. This card challenge I think is perfect for. Look into BEM link here

  • I highly recommend using background-image for multiple images on the body. Example take from here for more info. It will be tricky but once you get the background-image setup. Focus on getting background-size and finally background-position

#example1 {
  background-image: url(img_flwr.gif), url(paper.gif);
  background-position: right bottom, left top;
  background-repeat: no-repeat, no-repeat;
}
  • Another method instead of using <hr> for a border is to wrap the upper section of your card to a div and add a bottom border to it.

  • For your <section> container. They normally require a heading tag. Starting between h2 to h6.

Good work and keep on coding!! 👍

2

Alexei 831

@Batareika007

Posted

Thanks very much for your work, it's very helpful to get that useful feedback !

0
P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hey, Alexei! 👋

Great work on this challenge! Your solution looks good! 👏

In addition to artimys' great feedback, I suggest using flexbox on the body to center the card component in the middle of the screen (rather than a container div and margin) so that the card always remains nicely centered when the viewport is resized. It'll be a little easier, too, I think. 😉

Keep coding (and happy coding, too)! 😁

1

Alexei 831

@Batareika007

Posted

Thank you very much, yeah I need more practice at flexbox and I will do it ! never stop coding =)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord