
Solution retrospective
Can I get any sugestion for this challenge ? thanks
Please log in to post a comment
Log in with GitHubCommunity feedback
- @msuryaditriputraR
Hi Suryadi , we have the same name 😅
First I wanna congrats you for success to finish this challenge 😎🎉 and welcome to the Front-End Mentor community 🔥⚡
but I have some feedback for your solution ⚒
- Accessibility Issues
- Wrap all of the content with
<main>
tag, All page content should be contained by landmarks. - If you just have one heading, you have to use
h1
for semantic meaning and you can change its style but not the tag. The page should contain a level-one heading. - For the div's attribution, you should wrap it with
footer
, for better accessibility.
- Code & Design
- You should use CSS for change the background of
body
. Avoid usingbgcolor
attribute. - You forget to change the color of the card title, Please check the style guide to see the code hsl colors.
- For a style that is close to the origin, you should use
box-shadow
on the card
I hope this helps and can improve your code 🙌
Happy Coding ☕
Salam dari Makassar 👋😁
Marked as helpful - @shashreesamuel
Just as a follow up to the previous comment by Muh Suryadi Triputra Rahman, you can read up on semantic tags here
https://www.w3schools.com/html/html5_semantic_elements.asp
I hope this helps
Cheers Happy coding 👍
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord