Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Using CSS

Suryadi Harun•10
@suryadihrn08
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Can I get any sugestion for this challenge ? thanks

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Muh Suryadi Triputra Rahman•380
    @msuryaditriputraR
    Posted over 3 years ago

    Hi Suryadi , we have the same name 😅

    First I wanna congrats you for success to finish this challenge 😎🎉 and welcome to the Front-End Mentor community 🔥⚡

    but I have some feedback for your solution ⚒

    • Accessibility Issues
    1. Wrap all of the content with <main> tag, All page content should be contained by landmarks.
    2. If you just have one heading, you have to use h1 for semantic meaning and you can change its style but not the tag. The page should contain a level-one heading.
    3. For the div's attribution, you should wrap it with footer, for better accessibility.
    • Code & Design
    1. You should use CSS for change the background of body. Avoid using bgcolor attribute.
    2. You forget to change the color of the card title, Please check the style guide to see the code hsl colors.
    3. For a style that is close to the origin, you should use box-shadow on the card

    I hope this helps and can improve your code 🙌

    Happy Coding ☕

    Salam dari Makassar 👋😁

    Marked as helpful
  • Shashree Samuel•8,860
    @shashreesamuel
    Posted over 3 years ago

    Just as a follow up to the previous comment by Muh Suryadi Triputra Rahman, you can read up on semantic tags here

    https://www.w3schools.com/html/html5_semantic_elements.asp

    I hope this helps

    Cheers Happy coding 👍

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub