Skip to content
  • Learning paths
  • Challenges
  • Solutions
  • Articles
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Using css & js

Axel Quintana•120
@Leracius
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Imran Khan•370
    @astr0n0mer
    Posted over 2 years ago

    Hello @Leracius, nice work on your solution.

    Here are some areas that you might want to improve upon

    HTML:

    • While it would make sense wrapping the component in a <section> in a bigger project, but for this challenge, you can replace the <section> tag with <main> tag

    CSS:

    • Rather than using width directly, you can set #container's width:min(95%, 570px);. This way, it will always be 95% of the parent's width, and will take 570px as the maximum width.
    • In general, try to avoid giving width to block level elements
    • This course by Kevin Powell would be helpful in clearing out some responsive layout problems

    Well done, it's a great solution 😁😀

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub