Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

USING HTML AND CSS

@AMANDEEPSINGHBHALLA

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Nneoma Njoku 1,210

@SatellitePeace

Posted

Hello @AMANDEEPSINGHBHALLA nice work

But is an observation and tip

-the background color is meant to cover your entire body

and for the grey color to cover the entire screen you have to remove the width and height you set to the mainf container so instead of

.mainf{
  width: 80vw;
  height: 80vh;
  margin: 4rem auto;
  background-color: hsl(212, 45%, 89%);
  display: flex;
  align-items: center;
  justify-content: center;
}

- why not do this

.mainf{
  display: flex;
  align-items: center;
  justify-content: center;
}
- I removed the height, width,  margin, and background-color

body{
  margin: 4rem auto;
  background-color: hsl(212, 45%, 89%);
}

- added the margin and background to the body element

  • i believe this will make your project more visually appealing but other than that your work is neat

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord