@shashilo
Posted
Hey Esraa. You're getting better at implementing designs, but I do see some areas that you can improve on:
- The overall container should be
max-width: 920px
. - The method you are using to vertically and horizontally center the project is not ideal. It's not fluid and responsive. I'd remove this and make it
margin: auto;
. Because you're already using flexbox, addplace-items: center;
. This will center the elements vertically and horizontally. - In the left column, the icon box sizes are inconsistent.
- Please check the font spacing, white bubble background color, details of the design. There are many little things off about this implementation. Please use PixelPerfect to overlay the design on top of your implementation to view the details I'm talking about.
- The mobile view is pretty good aside from some padding issues.
- Look into implementing your CSS mobile first.