Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Validation a form with JS! :)

GabrielAlberini•60
@GabrielAlberini
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


At the moment, I have done three projects. This time, I share the last of them. I incorporated JavaScript in the validation of a form. Hope you like. I know that I still have many things to improve. Any help or advice is welcome :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jason P•20
    @JasonP670
    Posted over 3 years ago

    This looks really good. In fact when I first opened it I thought it was an ad so I closed it. I think that says how good it looks. I just wanted to point out that I'm looking at this on my phone. And on my phone the text in the green button gets cut off because it tries to expand beyond the end of the button. Good job! Looks really good!

    Marked as helpful
  • Ken•4,915
    @kens-visuals
    Posted over 3 years ago

    Hey @GabrielAlberini 👋🏻 it's me again 😂

    I know you're currently working on JS, but let's not forget about responsiveness of the project, I've got some feedback that might be helpful. I'm assuming that you're not building the website with mobile first principle, please correct me if I'm wrong. So I'm going to suggest everything with @media (max-width: SOME_NUMBER) {}. If you're not familiar with media queries, here is a link from CSS-Tricks that mentions everything about it.

    • So to make it responsive on both mobile and tablet viewport widths, let start from @media (max-width: 758px) {}
    @media (max-width: 758px) {
        flex-direction: column;
        text-align: center;
    }
    

    add this to lines to .container and like a magic, your website is responsive now. All you have to do is to play with font-sizes, so they're not huge on the mobile screen.

    I hope this was helpful 👨🏻‍💻 don't be shy Gabriel, have to admit that you made it really close to the design as well 👌🏻 Cheers 👾

    Marked as helpful
  • GabrielAlberini•60
    @GabrielAlberini
    Posted over 3 years ago

    Oh! Tanks you so much for your feedback Jason! :) I will try fix what you tell me.

    Although it is rare, that error does not appear to me. I'll take a good look. 8)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub