Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Vanilla CSS, Flex, Grid, Mobile-first, BEM, Responsive Landing Page

Anar 700

@anar-sol

Desktop design screenshot for the Skilled e-learning landing page coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello!

I had some trouble placing the hero image in intermediate sizes (especially between 480px and 768px). If you have a better solution than mine, I'd be glad to hear about it.

The W3C HTML validator considers it invalid to place a h2 inside a ul. I placed it there to have it as a grid element and place it among the li elements.

I then placed it inside a li, but I wonder if this is an accessible solution.

Any other advice is welcome =)

Community feedback

@HA3IK

Posted

About the “list”: I think that this is not a semantically correct solution.

Even if the H2 outline, at the current position, extends to the entire SECTION correct. I don't see the point of making the title, in the markup, a list item. H2 should be just a heading for the UL, not an item of it.

SECTION > H2 + UL > LI*5

I also saw that you have a duplicate ID linearGradient#a. You can easily fix this by simply declaring a generic SVG[height=0] somewhere separately on the page, it should work:

<svg height="0">
  <defs>
    <linearGradient id="a"> ... </linearGradient>
  </defs>
</svg>
0

@HA3IK

Posted

Hello, About “hero-image”.

But 1st: it's a very nice effect u got 👍 I'd leave it 😅

If you want to control this image within its position, you just need to disable its absolut position (make it position:static) THEN or change object-fit to "contain", or add overflow:visible.

IF you plan to center everything in one column (like on the mob.): .hero__body { margin:0 auto }

ELSE IF you want to keep .hero__body and picture horizontally, just make the parent element Flexbox .hero__container { display:flex }

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord