Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Vanilla CSS without design files, but with PerfectPixel extension

Obtez 10

@Obtez

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Biggest issue I had was getting the fonts right (which I still didn't) as well as the shadow of the Payment Button.

Community feedback

P
Katrien S 1,070

@graficdoctor

Posted

This actually looks quite good. Maybe the font-size in the button could be a bit smaller, but I see no issues. Well done!

  • Try to go for a mobile-first approach next time. You won't see the benefits of it yet, but once the projects get bigger, you'd be happy to have to write less code compared to when working desktop-first. Also be aware that iPhones have a width of 320px. And the new Samsung even has 280px. So setting your max-width on 375px is leaving out quite some users to enjoy the responsiveness.

  • Oh yeah, don't set the font-size on :root. In terms of accessibility this is bad. There is people that adjust their browsers so they can read better. By adding the font-size on :root you overrule their settings. Same with body. Try setting them as rem-values on the p-element.

  • The width on body is not necessary.

Looking forwards to see more of your work. Happy coding!

Marked as helpful

1
Obtez 10

@Obtez

Posted

Hi Katrien

Thanks a lot for your feedback. Not starting with mobile-first is a typical pitfall I fall into. Will try to keep your suggestions in mind for the future.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord