This actually looks quite good. Maybe the font-size in the button could be a bit smaller, but I see no issues. Well done!
-
Try to go for a mobile-first approach next time. You won't see the benefits of it yet, but once the projects get bigger, you'd be happy to have to write less code compared to when working desktop-first. Also be aware that iPhones have a width of 320px. And the new Samsung even has 280px. So setting your max-width on 375px is leaving out quite some users to enjoy the responsiveness.
-
Oh yeah, don't set the font-size on
:root
. In terms of accessibility this is bad. There is people that adjust their browsers so they can read better. By adding the font-size on :root you overrule their settings. Same withbody
. Try setting them as rem-values on the p-element. -
The
width
onbody
is not necessary.
Looking forwards to see more of your work. Happy coding!
Marked as helpful