Skip to content
Submitted over 3 years ago

Vanilla JS, Leaflet Maps, and IP Geolocation API

Genevieve•380
@bibmode
A solution to the IP Address Tracker challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

This has been my favorite challenge from Frontend Mentor so far. I learned how to read and use API docs with this one. Feedback or tips on how to make my code more efficient is much appreciated.

Code

Please log in to post a comment

Log in

Community feedback

  • John•250
    @JohnBroers

    Really nice job on your solution. Looking spot on with the design. Your sass and javascript is looking well structured. Nice job on using mixins for breakpoints and using css variables.

    A couple things that i noticed in your javascript:

    1. I don't think you need to declare lat and lng variable in the global scope. You only set it once in the function, and pass is on to other functions as arguments. No need to declare it global i think.
    2. I see one 'var' variable which you might wanna change into a const.

    Another thing i noticed here in the accessibility report is that the submit button is missing a text label for screen readers. You might wanna add a screenreader only text element or add an aria-label to fix that issue.

    I agree with you that it was a fun challenge to work on, had a great time working on it as well.

    Marked as helpful
  • Harmanjot Singh•985
    @arkharman12

    I am getting "Insert a valid IP address" on every IP address I tried to enter?! 🤔

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord