very responsive

Community feedback

• 

  P

  Timothé Bissonnette•480

  @Fable54321

  Posted 10 months ago

  Ok, so i'm not gonna dig too deep into this, but looking at your code, first thing I noticed is that all your css is in your html file using the tag.

  Just type how to link CSS to html on google, it will take you 2 minutes to grasp and it will make your code look much cleaner :).

  Now I don't know if you have noticed, your layout is centered at 1440px, wich shows me you"ve used the width given in the style guide, good job on that. The issue is the layout is not centered on any other widths.

  The more I look at your code the more I realize this might have been a bit of a nightmare for you. Don't worry, not so long ago I wante d to break things trying to center something using CSS.

  The first issue lies in your body selector. I see an align-content. First, align-content is a property that only works on flex containers. Second, I would tell you not to worry with the align-content for now, it is rarely useful.

  What you would need in this case is a display of flex, a justify-content of center and an align-items of center. This will center your layout in realtion to the body. Wich leads me to the fact you have use a fixed height. Now this is fine for a project like this wich you know will never take more than the screen height (at least on desktop), but in other cases you should switch from "height" to a "min-height" of 100vh, this will allow it to "follow" the size for your project.

  If you do all the above steps you wouldn't have the mess I see realted to margins on your container selector, because everything would have been centered from the beggining :).

  So, I won't dig deeper into it, Overall it looks good, the sizes are not exact but the proportions are pretty much kept so it looks good.

  Good job, keep up!

  02