Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Vite + Typescript + Zod + Styled component

react, typescript, vite, styled-components
geoffjecrois•390
@geoffreyhach
A solution to the Age calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello everyone, I'm excited to share my first Typescript challenge with you! As someone relatively new to Typescript, I would really appreciate any feedback you can provide on how I've approached typing in my code. This challenge was a great opportunity for me to learn and apply Zod for the first time, which was super helpful. Thank you in advance for your time and insights!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • jgambard•340
    @Tripouille
    Posted about 2 years ago

    Hello Geoffrey,

    Congratulations on your work! Here's some feedback on your usage of TypeScript.

    Avoid using 'any' unless for advanced stuff like generic: It's recommended to minimize the use of 'any' in TypeScript, as it can weaken the type safety benefits of using TypeScript. Instead, try to explicitly define the types of your variables, parameters, and return values to make your code more robust and maintainable.

    Provide function signatures: When typing a function, it's important to provide a function signature, especially when using 'setState' from React. This helps with type inference and makes it easier for other developers to understand the expected input and output types of the function.

    Consider using form validation libraries: If you're working with form validation using Zod, you might want to consider pairing it with a form validation library like React Hook Form. This can provide additional functionality and make it easier to manage form state and validation in a scalable and efficient way.

    Overall, great job! I hope this feedback is helpful in improving your usage of TypeScript. Keep up the good work!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub