Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Vs code

Muhammad-Ali-bhatti•40
@Muhammad-Ali-bhatti
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I have made this design using my knowledge i tried my best i am facing some promblems with responsiveness of the web page inshallah i will do my best

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Muhammad-Ali-bhatti•40
    @Muhammad-Ali-bhatti
    Posted over 3 years ago

    Thanks i will improve

  • anna•340
    @annab6
    Posted over 3 years ago

    Hello! Here are some things that you can improve:

    1. Border-radius on cards
    2. You are using the wrong font family for the paragraphs. It should be font-family: 'Lexend Deca', sans-serif; and font-family: 'Big Shoulders Display', cursive; for the headings
    3. Add text-transform: uppercase; on your headings;
    4. Change text color on buttons according to design
    5. Add more padding on buttons
    6. You can try to add hover effect on buttons button:hover{....} Happy Coding!
  • Muhammad-Ali-bhatti•40
    @Muhammad-Ali-bhatti
    Posted over 3 years ago

    Thanks for a look at my code. I am very happy to see your comment. firstly i box-sizing to border-box to move the content of the box inside without increasing the size of the box without this if u add padding to the box the box size increases to prevent this i use box-sizing to border-box. secondly i will improve my skills thanks :=)

  • Mojtaba Mosavi•3,740
    @MojtabaMosavi
    Posted over 3 years ago

    1- Use at leat two level lower heading for titles, its unlikely that you only have this component on a page and in the scenario you need to use you heading in a heirarchial.

              <h2>
                 and lower levels
             </h2>
        </h1>
    

    2- Use of sections are not necessary because you can set the same style on the div and it would give the same effect if you set the box-sizing to border-box which acounts for things like padding and borders.

    Keep coding :=)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub