VScode, Core CSS, HTML

Community feedback

• 

  Mahmood•2,130

  @MahmoodHashem

  Posted 12 months ago

  Great work on completing the challenge!

  However, I have some recommendations to help improve your code:

  • Consider using <main> to wrap your main content for better accessibility.
  • For headings, it's best to use <h1> to <h6> tags.
  • Move the inline styles from the HTML file to the CSS file for better code readability.

  Example:

  <main>
    <div class="container">
      <img src="./your-img-address" alt="">
      <h1>heading</h1>
      <p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Sint, consequuntur? Sequi dolore repellat praesentium voluptatibus odit? Nam ratione iure, quia eaque eos molestias laboriosam dolores autem, perferendis ex consequuntur suscipit.</p>
    </div>
  </main>
  

  I hope you find these suggestions helpful! Overall, great job on your work!

  00
• 

  Junior HTML developer•20

  @MaRiiaVoit

  Posted 12 months ago

  1. The solution includes semantic HTML.
  2. <p class="description">Scan the QR code to visit frontendMentor and take your coding skills to the next level</p> - I would make it brighter.
  3. I couldn’t find the README.md file with a description and screenshots of the site.

  00