Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

VueJS (SFC,composition api), Sass

Grzegorz Sterczewski•680
@gsterczewski
A solution to the URL shortening API landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first approach to Vue 3 and new features. My code needs some polish, because it's little messy right now, so I will eventually refactor it. For now I'm mostly interested in feedback regarding responsivness, html semantics and general UX, but any tips and opinions are welcome.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe
    Posted over 4 years ago

    Hey, Grzegorz Sterczewski! 👋

    Nice work on this challenge! 👍 I like the way the mobile navigation slides in! 😉

    I suggest,

    • Adding a max-width to the main container or wrapper so that the content of the page doesn't look too stretched on extra-large screens.
    • Making sure the text inside the "Get Started" buttons don't disappear when they are hovered over.

    Keep coding (and happy coding, too)! 😁

  • Grace•32,130
    @grace-snow
    Posted over 4 years ago

    Hey this looks nice! I like vue a lot and your components seem pretty clear.

    I'm seeing a few minor visual issues on mobile but should be easy to fix

    • hero img is spilling off the page to the right because of its width and margin. This is creating dead space to the right of that whole page. Either changes to the image css or to the body overflow-x should sort it.
    • other thing is the social links seem oddly off center but I couldn't understand what their css was trying to do to find a cause.

    Accessibility wise, you need to add clear focus states throughout, and make your menu button component use the button element. Those changes would make this work for keyboard users like me ☺

    Well done and keep going

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub