VueJS (SFC,composition api), Sass

Solution retrospective
This is my first approach to Vue 3 and new features. My code needs some polish, because it's little messy right now, so I will eventually refactor it. For now I'm mostly interested in feedback regarding responsivness, html semantics and general UX, but any tips and opinions are welcome.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @ApplePieGiraffe
Hey, Grzegorz Sterczewski! 👋
Nice work on this challenge! 👍 I like the way the mobile navigation slides in! 😉
I suggest,
- Adding a
max-width
to the main container or wrapper so that the content of the page doesn't look too stretched on extra-large screens. - Making sure the text inside the "Get Started" buttons don't disappear when they are hovered over.
Keep coding (and happy coding, too)! 😁
- Adding a
- @grace-snow
Hey this looks nice! I like vue a lot and your components seem pretty clear.
I'm seeing a few minor visual issues on mobile but should be easy to fix
- hero img is spilling off the page to the right because of its width and margin. This is creating dead space to the right of that whole page. Either changes to the image css or to the body overflow-x should sort it.
- other thing is the social links seem oddly off center but I couldn't understand what their css was trying to do to find a cause.
Accessibility wise, you need to add clear focus states throughout, and make your menu button component use the button element. Those changes would make this work for keyboard users like me ☺
Well done and keep going
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord