Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

w3schools.com , Angla Li bootcamp HTML and CSS

AntonSuperCoder•10
@AntonSuperCoder
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I don't understand how to build page for mobile users,it's took me time and i still don't know so i created qr code for desktop only for now it's only my second week coding so i still don't remember many things and i spent around 4 hours just to build this page.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 2 years ago

    Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

    I have some recommendations regarding your code that I believe will be of great interest to you.

    HTML 📄:

    • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.
    • The text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level is considered a simple paragraph and not a h2.
    • The indentation of the code is inconsistent, making it difficult to read and understand. It's recommended to use a code formatter tool, such as Prettier, in your code editor to automatically format your code and maintain consistent indentation.

    CSS 🎨:

    • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here 📘.
    • Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 350px or another value to make sure that the component will have a maximum width of 350px on any device, also remove the width property with a percentage value.

      .code-img {
          background-color: hsl(0, 0%, 100%);
          text-align: center;
          /* NOTE: Using max-width instead of width */
          max-width: 350px;
          /* width: 25%; */
          /* margin: 70px auto; */
          border-radius: 11px;
          /* NOTE: Use padding on all sides to prevent the text from touching the edges of the component. */
          /* padding-top: 20px; */
          /* padding-bottom: 35px; */
          padding: 20px;
      }
      
      img {
          /* NOTE: Update to 100%, the padding will prevent the image from touching the edges.*/
          /* width: 85%; */
          width: 100%;
          border-radius: 10px;
      }
      
    • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

      Using grid layout:

      body {
          min-height: 100vh;
          display: grid;
          place-content: center;
      }
      

    CSS Reset 🔄:

    • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

      CSS resets that are widely used:

      • Reset CSS
      • "My Custom CSS Reset" by JoshWComeau

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful
  • Vince•60
    @vincemarq01
    Posted over 2 years ago

    Make sure to use text-align to adjust the text to the center. Happy coding

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub