Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

w3school-youtube-how to ...

kamiya nakamiโ€ข 230

@kamiya-nakami

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Do you have any questions about best practices?

Community feedback

NitheeshKumar Cโ€ข 440

@NitheeshKumar-C

Posted

Hi there ๐Ÿ˜€,

I can help with some issues. You can make the body content center using flex-box,

Example for this problem:

body{
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

and remove margin: 10em 30%; from .QRcode.

If you think this is helpful please mark as helpful.

Happy Coding ๐Ÿ‘จโ€๐Ÿ’ป,

Nitheeshkumar

Marked as helpful

0
Travolgi ๐Ÿ•โ€ข 31,480

@denielden

Posted

Hi Kamiya, great work on this challenge! ๐Ÿ˜‰

Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible remove height from.QR-siz class
  • remove all margin from .QRcode class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • not use <br> for brea the text... make it wrap according to the width it has available
  • instead of using px use relative units of measurement like rem -> read here

Overall you did well ๐Ÿ˜ Hope this help!

1

kamiya nakamiโ€ข 230

@kamiya-nakami

Posted

@denielden Thanks for the advice and I will use it to improve on the new project .

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord