Web Ninja 101 | IP Address Tracker with HTML, CSS, JS

Community feedback

• 

  Arturo Simon•1,805

  @artimys

  Posted over 4 years ago

  Great job!! 👍👍 You did a good job with your JS. Different functions to hold your regex validation. Event listener and good technique of using a css class name to enable your error styles.

  • I can see why you added a set timeout to for your input error handling. If you want to keep that effect I recommend to just disabled the button when clicked and then enable it when the user types a valid format in the input box. A bit more code with a javascript keyup event with a setTimeout to delay the capture of user input can help prevent spamming the button (and redundant API calls).

  • Another suggestion I can add is the arguments to your getData() function. Set it for only one default argument. It can default to

  function getData(inputValue, searchType = 'IP') {
      // write a condition where if searchType equals 'IP' append to your fetch URL
      // else if 'DOMAIN' then append to your fetch URL
  }
  // will search by IP query by default
  getData(myInput.value)
  
  // will search by Domain query
  getData(myInput.value, 'DOMAIN')
  

  Hope it helps and keep on coding 👍

  23
• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hey, nice work on this challenge, Papa Elhadj Abdoulaye NDOYE! 👍

  Your solution looks good and works well! I like how you used to CSS grid to make the information box responsive (I haven't seen much of that in this challenge). 👏

  One tiny thing I might suggest is to set cursor to pointer for the search button next to the input element. 😉

  Keep coding (and happy coding, too)! 😁

  01