@VCarames
Posted
Hey there! š Here are some suggestions to help improve your code:
- Unfortunately, your content lacks responsiveness. Meaning that it does not look presentable in different screen sizes.
- To fix this, you will have to redo this challenge, using a mobile-first approach in which you style your design for small device first and use
media-query
to style for larger devices. This will ensure that performance and responsiveness are prioritized.
- Avoid using
ID
for styling and instead useclasses
.
- When starting a projects, it is best practice to initial your styling with a CSS Reset. This will help remove any inconsistent styles applied by the browser and speed up your coding.
- Your
email input
is missing alabel
which helps tell non-visual users what theinput
is for.
- The
EventListener
in your JS should be on theform
as asubmit
not aclick
, since the user is submitting their email; clicks are for actions.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! š¾
Marked as helpful
@nadezhda-frunza
Posted
@vcarames thanks for your comment! yes, I will work more on responsiveness in my next projects :)