Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Website with the email field submission (HTML, CSS, JavaScript)

nadezhda-frunzaā€¢ 150

@nadezhda-frunza

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My 6th challenge! This time I used a little bit of JavaScript, and plan to use it more and more in my future projects.

Community feedback

@VCarames

Posted

Hey there! šŸ‘‹ Here are some suggestions to help improve your code:

  • Unfortunately, your content lacks responsiveness. Meaning that it does not look presentable in different screen sizes.
  • To fix this, you will have to redo this challenge, using a mobile-first approach in which you style your design for small device first and use media-query to style for larger devices. This will ensure that performance and responsiveness are prioritized.
  • Avoid using ID for styling and instead use classes.
  • When starting a projects, it is best practice to initial your styling with a CSS Reset. This will help remove any inconsistent styles applied by the browser and speed up your coding.
  • Your email input is missing a label which helps tell non-visual users what the input is for.
  • The EventListener in your JS should be on the form as a submit not a click, since the user is submitting their email; clicks are for actions.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! šŸ‘¾

Marked as helpful

0

nadezhda-frunzaā€¢ 150

@nadezhda-frunza

Posted

@vcarames thanks for your comment! yes, I will work more on responsiveness in my next projects :)

0
Himanshu_2301ā€¢ 320

@Himanshu-196018

Posted

Hello @nadezhda-frunza, It looks good.

Btw I have gone through your code and looked around a bit, your button seem a bit mispositioned. You can give <form> element a position relative to align your button more accurately same goes for error icon too.

I hope this was helpful.

Marked as helpful

0

nadezhda-frunzaā€¢ 150

@nadezhda-frunza

Posted

@Himanshu-196018 thank you for your comment, appreciate it! :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord