@denielden
Posted
Hey Igor, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- use
h2 or h3
element for the title of country instead of ap
- use
ul
element for the details text of country instead of multiplep
- if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- add
header
tag and wrap the navbar for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - check the data on the details page otherwise it will go into error if any data is missing as it happens in the Antartica page country
Hope this help! Happy coding 😁
Marked as helpful
@igor-ostojic
Posted
@denielden Regarding the
- "in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
I found it weird that the original design didn't show a "all region" option, and I always try to follow the challenge as close as possible
Thanks for all the advice !