Aayush Kumar
@AK-CHP1All comments
- P@cvalencia1991@AK-CHP1
Hi @cvalencia1991! Congratulations on completing this project. I think you can further improve the typography of your paragraph by adding
line-height: 1.5
. Also consider using CSS grids to properly leave gaps around your cards. Your.stylenumber
element also seems larger than the card's heading, consider making it quite smaller.Rest looks great!
Marked as helpful - @gopinath-97@AK-CHP1
Congratulations on completing this project
Your solution looks good. But I think you can further improve this solution by;
- Adding a
line-height
of 1.5 to your paragraphs - Using flexbox in your
.content
element for proper alignment and spacing of different components.
Happy coding!
- Adding a
- @Teke111@AK-CHP1
Congratulations on completing this project
I think you can further improve your project by using media queries to change layout for mobile devices (
max-width: 375px
as per the style guide)Also you can learn the basics of flexbox at:
- MDN here
- Wes Bos's free course at flexbox.io
Please consider checking my solution here and provide some feedback.
Please let me know it that helped.
Thanks
- @elder-ramos@AK-CHP1
Congratulations on completing the project
I think the project would look better if you vertically center the
.card
section element. You can do that either by playing with margin values or using something like flexbox or positions (margin: auto
doesn't help in centering vertically, you could instead usemargin: <some value> auto
) . Also consider settingfont-size
ofp
element to 15px (as mentioned in the style guide), because it seems too small and almost becomes unreadable on small viewport. You should also use media queries to make some changes with the card for mobile layout.All the best. Please consider checking my solution of this problem here
Any feedback and suggestions on how I can improve are very welcome!
Marked as helpful