Latest comments
- @wojocode@ASH2001prince
Hello Wojtek Natkaniec congratulations for this project
- I think you have a super responsive design here but I have something that I noticed like the main height if you remove the
margin : 0 0;
and add apadding : 20px
the height of the page would be much better. - I`m not sure about this but I think working on the grid system here if easer I have done this project before and this is how I worked on the main container:
.cards{ display: grid; grid-template-columns: repeat(4, auto); justify-content: center; align-items: center; }
Hope you find it helpful
- I think you have a super responsive design here but I have something that I noticed like the main height if you remove the
- @Jmlsoteyza@ASH2001prince
Hello jom congratulations for your new project -I have some HTML tips for you:
- you can use the <section> or <article> elements to gather the elements like the <h1>,<p> and <img> together.
- instead of coping the <svg> you can import the image by using <img> element.
- <footer> usages for the last informations like names some links maybe and we can put the <address> attribute inside it as well.
Marked as helpful - @YoussefTadarti@ASH2001prince
Hello @YoussefTadarti congrats for your first attempt I got some tips for you
--HTML
- instead of adding the <div> as a container you should have put the <main> element.
- And the <div> card as a <article> and at the same time the <article> as a section,
--CSS
- Its kinda tricky positioning the card by using the margin i think its better using this code:
display: flex; justify-content: center; align-items: center;
- I did this project a couple days ago and this is how i designed the card => my main container:
.cards{ display: grid; grid-template-columns: repeat(4, auto); justify-content: center; align-items: center; }
hope you find my feedback helpful.
Marked as helpful - @VMahluza@ASH2001prince
Hello VMahluza welcome to the frontend mentor community _here are some tips for aligning the card.
- instead of using the <div> element everywhere you use the <main> as a container and <section> .
- for aligning the card you give the body selector these values:
body{ min-height: 100vh; display: flex; justify-content: center; flex-flow: nowrap column; align-items: center; align-content: center; }
--keep it up
Marked as helpful - @Siddhesh877@ASH2001prince
Hello Siddhesh Parate congratulations for your first attempt here some tips that I can share it with you :
- In the html part you should use the <main> element as a container for all the elements instead of the <div>.
- if you want a responsive design you should`ve give a width and height values instead of auto.
- for a last thing aligning the body to the center would much easier, like so:
display: flex; align-items: center; justify-content: center;
hope you find it helpful
Marked as helpful - @abbas-roholamin@ASH2001prince
Hello Abbas Roholamin you did an amazing job with this project I did this project a couple days ago and I didnt use the grid in it so it didnt become responsive
as it should be so I think that you did the best practice in here. -keep it up broMarked as helpful