Skip to content
OverviewSolutions
32
Comments
21

Abdihafid Adan

@Abdul400Nairobi, Kenya780 points

I am passionate about coding and what it can do to make the world a better place

Latest solutions

View more solutions

Latest comments

  • Abdihafid Adan•780
    @Abdul400

    hey @KaiPereira

    thank you for your feedback. I will be considering them for my next challenge. :)

  • Abdihafid Adan•780
    @Abdul400

    hello @Eman-AbdElZaher, Generally, your work looks really good and is very responsive. However, here are a few things I noticed.

    1. the link to your GitHub code does not work and there is no way of reviewing the code.
    2. I bypassed that by using the view page source in chrome web dev tools and noticed that you gave the hero-desktop image a width and height of 100% which squishes it when viewing devices with smaller width. I would recommend using the image as a background of the right-side and then positioning it accordingly using background-position.
    3. The form placeholder should also be the same color as that of the paragraph. You can edit the placeholder using ::placeholder property.

    Other than that. Good Job!!

  • Abdihafid Adan•780
    @Abdul400

    hello @AnulQr. I think your work generally looks really good particularly for the desktop view. However, I noticed a few things.

    1. It is responsive but the pages have not been optimized well for mobile devices and tablets.
    2. The responsive layout transitions to quickly to the mobile view too quickly and according to your code, I can see that you started with mobile-first development, which is not necessarily a bad thing. However, you have to consider other devices too. I believe the transition from desktop view to mobile view should be from around 375px, but I usually start around 500px to cater for 'phablets' because phone screens are getting bigger. There should also be tablet devices maybe starting from 500px to around 800px or so. Then the rest is desktop view. kindly consider such devices in your development.
    3. The background does not match the one outline in the design files. consider incorporating it and adjusting it accordingly.

    Other than that, Great Job!

    Marked as helpful
  • Abdihafid Adan•780
    @Abdul400

    hello @Mhmd-Tarek-Mhmd,

    I noticed that the JavaScript functionality for email validation works only when the email is invalid. as per the design files, I believe you should also have a (green text) notification when the email is valid. I also noticed that the background positioning is a bit off. Use the background-position property to position your background.

    Other than that, excellent work!

    Marked as helpful
  • Abdihafid Adan•780
    @Abdul400

    hi, @sqle157.

    Generally, everything looks good and scalable. However, I think you have to work on the hover states for instance, use cursor: pointer on the hover states for the avatar image, and also the name in the NFT component. Also, to allow for accessibility, kindly wrap the primary contents in a main html attribute. On the same note, provide alt descriptions for your images to also allow for accessibility.

    Otherwise, nice Job for having a clean and readable code!

    Marked as helpful
  • Abdihafid Adan•780
    @Abdul400

    will definitely do so. Thank you for sharing your resources. I will definitely look into them.

View more comments