All comments

• 

  uzumakiabba• 80

  @recklessboss

  Submitted over 3 years ago

  newbie...Please i need feedbacks thanks

  

  Bootstrap,Javascript,Flexbox

  1

  2

  0

  

  Eric Akoten• 175

  @AceKahuna

  Posted over 3 years ago

  Hello there Uzumakiabba, hope you doing fine. You have done good and the code looks fine and congrats on finishing that challenge. There are a few things that you need to put into consideration. As you can see, you didn't add the background image instead of the plain hair. background-image: url('/intro-component-with-signup-form-master/images/bg-intro-desktop.png'); As you can see you have used the wrong path to the image instead use background-image: url('/images/bg-intro-desktop.png'); You can tweak the widths and padding to match the design. Once again Congrats

  0

  This comment has received 2 repliesShow
• 

  Victor• 110

  @VictorSanchez25

  Submitted over 3 years ago

  Hi Guys! This is my first challenge and I'm new at this. It would be much appreciated if you take a quick look and give this a short feedback. Thank you so much!

  

  Fylo Data Storage using HTML and CSS

  1

  2

  0

  

  Eric Akoten• 175

  @AceKahuna

  Posted over 3 years ago

  Hey there Victor, the code looking good and good job on your first challenge. Just like in the report, use the forward-slash instead of the backslash to avoid such issues <link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png"> The responsiveness is smooth needs just a lit adjustment on the padding and width so that it can match the design. Congrats again, looking forward to more of your projects submissions.

  0

  This comment has received 2 repliesShow
• 

  Ben Seagrave• 105

  @BenSeagrave

  Submitted over 3 years ago

  I would love any feedback you can give, especially how I can use more of SASS' features in my code. I feel like all I am really using is the nesting feature so I'm curious if I should revert back to normal CSS for small projects like this?

  

  Intro component with sign-up form in HTML, SASS & JavaScript

  1

  1

  0

  

  Eric Akoten• 175

  @AceKahuna

  Posted over 3 years ago

  Hey there Ben, checked out your code and it looks fine. No need to worry about nesting since it helps out define the properties much efficiently and helps avoid making mistakes while calling a certain class or an element in vanilla CSS. On the media queries, you can create a @Mixin instead of having to write the code manually.

  @mixin tab-land{
    @media screen and (min-width: 992px) {
      @content;
    }
  }
  

  Set a min-width and max-width for the elements to avoid it squishing in the mobile view

  1

  This comment has received 5 repliesShow