Skip to content
OverviewSolutions
33
Comments
31
P
AdamullaOsas
@AdamullaOsas

All comments

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Wow, your page looks very good, honestly nothing more to add

  • Peter Godspower•710
    @TheBeyonder616
    What are you most proud of, and what would you do differently next time?

    This is my first time working with API

    What challenges did you encounter, and how did you overcome them?

    Coming up with the logic for the country border

    What specific areas of your project would you like help with?

    Any advice would do

    Interactive Country App: Built with JavaScript, Focused on Accessibili

    1
    P
    AdamullaOsas•800
    @AdamullaOsas

    You're crazy writing this in html file hahahahah, I really like this little features (like this button moving you to the top or rainbow borders). Although you need to work a little bit on spacing elements and styling, but rest looks just fine

    Marked as helpful
  • P
    AdamullaOsas•800
    @AdamullaOsas

    you definitely should improve your styling and add your own validation, becaulse I can't put values like 5.25 inside interest rate. Also on mobile devices you shouldn't have these strips on the sides and it should take full screen

  • P
    AdamullaOsas•800
    @AdamullaOsas

    bro xd

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Your page looks very similar but there are a few changes to make:

    • you're missing hover effects
    • you haven't added responsiveness to mobile devices
    • also you should center this overall score on left side
    Marked as helpful
  • P
    AdamullaOsas•800
    @AdamullaOsas

    good job, your page looks great

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Your page looks good, but not perfect, the first problem I saw is your layout in home page, images are not perfectly fit, as they should. You can look up for mansory layout in google and get some help from there, or just assign pictures to their columns by some id or something. Also you dont have much hover effects and progress bar. I took my time to design mine, but the best way is to calculate value and assign it to variable and then use gradient to a div with position absolute right above footer.

  • P
    AdamullaOsas•800
    @AdamullaOsas

    You should mostly work on your sizing, page should take full width and height of page without white strips on the sides. Try applying background image on full size window, not the same with max-w-[xxx], becuse this is the reason of these white lines.

    Marked as helpful
  • P
    AdamullaOsas•800
    @AdamullaOsas

    good job, I really like your image slider, but you dont have a hover effect on 'Shop now" button. The rest looks just perfect ;)

  • mofada•340
    @mofada
    What are you most proud of, and what would you do differently next time?

    I think it is difficult to take care of both mobile and desktop at the same time.

    loopstudios-landing-page with tailwind css

    #tailwind-css
    1
    P
    AdamullaOsas•800
    @AdamullaOsas

    your page looks great, but I when I click on a hamburger icon on mobile view nothing happens. Also I've seen your code, and maybe you should try to avoid DRY code (don't repeat yourself) because e.g. you have 5 links with the same classes and it just doesn't look great

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Your coloring and styling looks pretty well, but there are some misplaced elements that could be fixed with one line of code align-items:center try using this in flexbox elements to align items horizontally (for example this avatar picture and text would be at the same height)

  • P
    AdamullaOsas•800
    @AdamullaOsas

    I really admire your job, the one thing I can give an advice to you is choosing colors provided in the design, but the rest (spacing and functionality) is very well done

  • P
    AdamullaOsas•800
    @AdamullaOsas

    It's very similar to the design, page looks good. Functionality also works very well. One thing I can give as an advice is that you should break down your 500lines of code into smaller components, so it's more readable and easier to understand.

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Your page looks mostly good, but there are a few changes to make:

    • Hovering over navbar links should show orange strip below the text
    • You should not be able to put negative values as a number of item
    • Items should be added to cart after clicking button, not after putting number of items

    But Im really big fan of your image slider and its smoothness

  • P
    AdamullaOsas•800
    @AdamullaOsas

    Your desktop view looks great! The use of CSS Grid is impressive. However, the mobile view could use some improvements. Right now, below 480px, the page isn't scrollable, making it difficult to access the navbar. You might want to add something like min-height: 100vh to the container, so the page remains scrollable if content overflows.

    Also, ensure responsiveness across all devices, not just the ones specified in the task. For example, the layout becomes unreadable below 1000px, with part of the navigation cut off. Try to avoid using fixed widths like width: 1110px; instead, consider using margins, paddings, and gaps to create space. You could also use max-width: 1110px if necessary. This will make your page more adaptable to smaller screens.

    Marked as helpful
  • P
    AdamullaOsas•800
    @AdamullaOsas

    You can try to size it better to look more like in a design, but overall frontend looks good. Your errors messages works flawlessly. But there is no alert poping up or email validation

  • P
    AdamullaOsas•800
    @AdamullaOsas

    very good job, looks almost the same as the design while keeping the functionality

  • P
    AdamullaOsas•800
    @AdamullaOsas

    App functionality looks good, but you need to pay more attention to sizing, spacing and colors provided in style guide to improve readability