@developertarik
Ahmed Alharees
@AhmedAlhareesAll comments
- @AhmedAlharees
Hi @developertarik. There's problem in solution is that the submit button doesn't function properly. I hope you notice it soon.
- @Nachoho@AhmedAlharees
This is a wonderful solution @Nachoho. But the card is supposed to be centered vertically in the middle of the page, in your solution it's on the top. a solution for this problem is setting the body to 'display: flex' instead of display grid, and apply these changes also: body{ height: 100vh; display: flex; align-items: center; justify-content: center; } and the problem should be fixed. and if you want to keep the attribution div to the buttom, add "flex-direction: column". Good luck.
- @jose-jimmy@AhmedAlharees
Nice solution mate👍🏻. but I don't know if it suppose to do that, but when I write an email and press enter I'm transferred to a blank white page for some reason, I hope you fix that. Other than that, it's nice, keep it up.
Marked as helpful - @ferditondeur@AhmedAlharees
Nice job completing this challenge 👏 couple of notes for you:
- try separating the CSS code into different file, that's the best practice, and It will certainly makes it easier to work with.
- try giving the cards more space on mobile layout, it will make them look better.
- It doesn't matter in small project if it's flex-box or grid, they are both amazing and get the job done, plus if it works it works😅. other than that, good job, and good luck for you.
- @MelvinAguilar@AhmedAlharees
Nice work <3.
- @correlucas@AhmedAlharees
WOW! what an amazing vision for this challenge.
- @ashtagmujib@AhmedAlharees
Honestly, it's beautiful. but i don't know if my screen is too large or something, but there's a white gap on the right, and all the website is pushed to the left. Plus the website doesn't work on smaller screen sizes. I hope you notice that <3.
Marked as helpful
