Skip to content
OverviewSolutions
31
Comments
21

Alucard

@Alucard2169870 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

I’m currently learning...

Three.js Next.js

Latest solutions

View more solutions

Latest comments

  • Alucard•870
    @Alucard2169

    hi, you did a great job in this challenge, there are some issues, one of them is the share button (when the user clicks the share button , it opens up the share menu, but if the user decides to not use it, they would have to reload the browser to close the share menu)

    if added a state functionality, it will keep the current state of the share menu ( if it's open or not), i have explained it in the pull request on github.

    hope it help, if you have any other issues, just ask

    keep it up

    Marked as helpful
  • Alucard•870
    @Alucard2169

    hi, i fixed some of the issues, i have explained them in the pull request, hope it helps

    avoid using inline css

    overall you did a very good job

    keep it up

  • Alucard•870
    @Alucard2169

    Hi, Great job on the design,

    next you should try to make it interactive and functional, as it will give you tons to learn on the way.

    Here is how you can fix your HTML and Accessibility errors:

    • you should always change heading size by one, for example ( a page must have a H1 heading (very important), after that you should decrease the size by one like h2 > h3 > h4 ...., don't just jump to h3 or h4 );

    • Input element must have a label all times, here is how you can do that

     <label for="{your input's ID}">   *some_text*    </label>
 <input id="{your input's ID}" >

    hope that helps

    Marked as helpful
  • Alucard•870
    @Alucard2169

    hey @yurideoliveira,

    Great job you design looks great,

    to solve the accessibility issue, you should use at least one <h1> element in you page.

    Happy coding!

    Marked as helpful
  • Alucard•870
    @Alucard2169

    hi @luisoliverosrdn,

    You did a awesome job.

    • here are some points to help you:-

    -- use display: flex and a flex-direction of column with height 100vh on body, to center the card perfectly.

    -- you don't have to use alt attribute on anchor tag.

    happy coding!

    Marked as helpful
  • Alucard•870
    @Alucard2169

    Hi,

    • Design look good, but a bit too small, so you should work on the dimensions to make it more visible and stand out on the screen.

    • The formula you used to calculate the tip and total amount aren't working properly, you can look up online to see the correct formula for tip-calculator.

    • The reset button is suppose to clear every input and amount display, and bring everything back to square one. You should work on that.

    • People input isn't suppose to take negative or fraction values.

    • Bill input and custom tip input isn't suppose to take negative values.

    • Using attributes like hiddenheading and zero-people on html element is not valid, if you want to set something to hidden you can use CSS or JS for it.

    Best of Luck

View more comments