Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • ronaldlamdev• 430

    @ronaldlamdev

    Submitted

    My first project to access an API. I'm still a little confuse on how async functions work despite researching the topic, but that's ok. Developers are constantly learning and improving. Feedback is welcome :)

    @ArpadGBondor

    Posted

    Looks good. :)

    Maybe try to set "max-width" for your <main> element, so the advice won't spread all across the screen. Also maybe try to use media queries to set different design for mobile and desktop views.

    Marked as helpful

    1
  • @ArpadGBondor

    Posted

    Thanks for reviewing my solution, I also checked yours. :)

    Nice use of relative units, but I think the one place you should not use them, is setting up media queries. Relative units are great when we don't hardcode the font-size of the root element to a fix value, and we let the browser to change font sizes, but we shouldn't switch between mobile and desktop view just because the root font-size changed.

    An other thing I noticed, there's an extra picture in the document showing that the button should change it's border+background color when you move the mouse over it. You can set it by adding a new css rule with ".cta:hover{}" selector. Use "cursor: pointer" to change the mouse here as well.

    0
  • Parth• 75

    @ParthPatel76

    Submitted

    Please review the code and design. I Would appreciate your feedback for the same. I have tried my best to make the design as close as possible to the given challenge.

    Thank-you!! Parth :)

    @ArpadGBondor

    Posted

    try setting "max-width: 1100px;" on the component on desktop view

    on the image, try using "object-fit: cover"

    0