Ayoife
@AyoifeAll comments
- @JordanKisiel@Ayoife
Wow!!, This is the first solution for this challenge I've seen that matches the design perfectly and you did it without Figma right?!!, Nice work!
- @dayerlin-bustamante@Ayoife
Hi @Dayerlin Bustamante, Congrats on completing this challenge!!
It looks really good and I like the way you made yours unique by using red instead of a green color for the button and the header, Nice work. But I couldn't help to notice that the font family of your solution wasn't the same with that in the design. I checked your code and I found out that the problem was the
@import
statement. The@import
statement on the first line of your css was not correct because,- Firstly, all links/urls should be contained in an
url()
function, therefore the url specified is actually visited - And secondly, the link in the
@import
statement is going to take you where the font is located on the Google Fonts website and returning nothing to your css but what you should have done was to scroll to where you could find the styles of the font family(in this case Manrope, and a font weight of 800) and then selected it and then copied the@import
statement it provided at the bottom right of the page to your css.
But to solve the problem, just replace the
@import
statement in your css with this :@import url('https://fonts.googleapis.com/css2?family=Manrope:wght@800&display=swap');
which I got from the Google Font website.But apart from that, your site was absolutely amazing, keep it up!!
- Firstly, all links/urls should be contained in an
- @mavix21@Ayoife
Your solution looks flawless, Keep it up!!
- @JudasThePriest@Ayoife
Hi @Galen, Congrats on completing your first challenge!!
I viewed your site from my phone and I found out that there was still some vertical scrolling, but if it makes you feel any better, I checked the mobile design for the challenge and there was also some vertical scrolling. But the main thing is that the users should be able to view the QR-Code Component properly which the solution you submitted passed but if you want to be finicky, then you can consider reducing the width and height of the
card
class to that of the design in the project folder and probably solve the scrolling problem. I hope I was of a little help and I hope to see many more completed challenges from you :)Marked as helpful - @cosmoart@Ayoife
Wow!!, this solution left my mouth wide-open, Absolutely amazing!!
- @catherineisonline@Ayoife
This solution is just WOW!!!
- @Ayoife@Ayoife
Alright, Thanks for your feedback
- @KTrick01@Ayoife
Not giving this solution a like ♥️♥️ should be a crime 😂😂. I would have given it a 100 likes if I could ☺️☺️. Thumbs Up! 👍👍
- @Rausalaa@Ayoife
Nice solution @Salaudeen, and about your question, the way I did mine was by adding a 'position' property to that 'attribution' class and setting it to 'fixed' then setting the 'bottom' property to zero. I hope I was of help to you :)
Marked as helpful