Skip to content
OverviewSolutions
15
Comments
6
Aishat Muhammed
@Aysha-py

All comments

  • Aishat Muhammed•360
    @Aysha-py

    Hi @JustANipple,

    This is an extremely responsive proect, welldone.

    I haven't worked with vite before, but I am curious is it a framework for react? does it come with its own components? and lastly did you use a css framework for this project?

  • Aishat Muhammed•360
    @Aysha-py

    Hi ABDOYASSER111,

    Welldone o n this challenge. I just check on my PC and I commend your effort in trying to get a near perfect design, but when I inspected on my PC to check other screen display, I notice it was not responsive.

    My advice is that, you can try using display - grid and grid-template-column so that when you default to mobile you can give each grid 1fr, this is to help you segment your sections or make use of the flex display and make your flex-direction column in mobile, so that the 2 sections stacks on each other when you default to mobile view.

    I also noticed you used a lot of absolute positioning, is there a reason for this?

    Nonetheless, welldone and Happy coding!

  • Aishat Muhammed•360
    @Aysha-py

    Welldone Julius, I love it, definitely trying this out after my currect challege. Great Job

  • Aishat Muhammed•360
    @Aysha-py

    Well done Bimbo. I love the interface of your design, it’s neat and responsive on mobile (I viewed on mobile)

    However, after inputting my email address, the success feedback still carries the default email address from the challenge. You can pass the email to a variable using your JavaScript. Also the dismiss button doesn’t work too. You wanted it that way?

    Marked as helpful
  • Aishat Muhammed•360
    @Aysha-py

    Nice work considering the fact that you are just using JavaScript for the first time. The Js code does work well

    However,I viewed this on mobile and I noticed after first submission and successful rating, the submit button on the initial page lost all its styling. You can try to fix that

    Marked as helpful
  • Aishat Muhammed•360
    @Aysha-py

    If you ever find yourself checking out my solution, i would love to hear some feedback from you. I am opened to corrections and improvement.