Skip to content
OverviewSolutions
21
Comments
5
BBualdo
@BBualdo

All comments

  • BBualdo•540
    @BBualdo

    Nice design!

    I've found only 2 issues in your project:

    1. In Languages you have object Object instead of languages.
    2. Some countries does not have their flags displayed correctly when you go to the detail view.

    I will let you opportunity to solve this on your own, but if you have some issues, I will be pleased to help you!

    Marked as helpful
  • BBualdo•540
    @BBualdo

    Hello, the design looks very nice, good job!

    I think the logic of your app is not perfect, because it should let you pick one of 5 ratings and then show the result. At this moment you can pick all ratings and additionally - you can't "unclick" clicked rating. Just write a function that checks if any rating is currently selected and if it is - remove selection and add to currently clicked one. Another approach (which I preffered) was removing selection from all rating elements and adding one to clicked. Good luck!

    Marked as helpful
  • BBualdo•540
    @BBualdo

    Hi, if you want to set different styles on different screen size you have to use media queries.

    To do this you can wrap all your styles in:

    @media (max-width: 400px) {
***your styles***
}

    It means that all of your styling will be applied until page width crosses 400px.

    So you can copy all your styles twice. One for @media (max-width: 400px) {} and one for @media (min-width: 401px) {} and then just style it for desktop. In that the changes won't be applied for Mobile View.

    And about responsiveness I have one advice: Avoid hard height and width settings of the elements unless you really have to do it. Pages are responsive by default. But if you have to do it temporarly, use max-width or min-width instead of width. Same rule for height. And try to set it with vw and vh instead of px.

    vw is ViewportWidth (100vw means it will always have width equal to page width). vh is ViewportHeight (100vh means it will always have height equal to page height).

    Good luck!

    Marked as helpful
  • BBualdo•540
    @BBualdo

    Elegancko to wygląda!

  • BBualdo•540
    @BBualdo

    And again, setting up width still looks weird here.