@christiano84
Basha
@BashamegaAll comments
- @Bashamega
Hello:) It is very good, and your code is clear and readably. The only thing I noticed was that you included the design folder and the README-template.md and the style guide and website-text but you should exclude this in your GitHub repo. Also try setting the active tab to be black but thee unactive tabs to grey
- @GermanGuerreroR@Bashamega
Hello:) It looks awesome. I have noticed 2 issues. First it is not very responsive on large screens, like it looks good on my laptop but horrible on my monitor. Also, you should add a hover effect for the button. and the confirmation the email should be the email that the user has entered, and you can achieve this with some js. However, the overall is great. I how you had a great time completing this challenge.
- @hanzala-bhutto@Bashamega
It is great, and awesome. I suggest that you try to use semantic html instead of divs like nav, main, and footer tags. Also I think the crew page should be a slideshow and the crew members images get a little bigger
- @LucianEmanuel@Bashamega
It is awesome, but I suggest make the images more bright by default
- @Twixii99@Bashamega
Hello:) It is very good and responsive. I suggest removing the default front end mentor style and also try using semantic HTML, for example use the footer tag instead of the div tag.
- @MrDevM@Bashamega
Hello Mulugeta I have checked it in my browser the responsive view, it is fine, but the image is stretchy. I suggest not specifying the height of the image or setting it to auto and this should resolve the issue
Marked as helpful - @yret1@Bashamega
Hello:) Your project looks great in the screenshot, but for some reason the buttons are on the Wikipedia link, and the details are not visible.
Also, you should set the cursor to be a pointer for the buttons.
Marked as helpful - @SalmaHazzem@Bashamega
Hello salma:) I have looked at your project, but I think that there should be some changes. I have noticed that the font is not the same as the font that frontend mento instructed and also I have noticed that the divider is not visible and also that the button icon is not the same. The starter code has the divider and the button images, so you don't have to create the image. Please read the instructions again and use the images from the starter code. But keep it up!
- @ICUBE321@Bashamega
Hello:) It looks great. I just noticed that the red dot on the unread messages is not showing, second I think it would be better if you can add some functionality to make the
mark as readbutton working. Other than that, keep it up! - @vgarmyWhat are you most proud of, and what would you do differently next time?
I like the mobil solution, and use of less code.
What challenges did you encounter, and how did you overcome them?Hade som problems with the image.
What specific areas of your project would you like help with?None
- @Djonali@Bashamega
Hello Djonali:)
I have tested your project multiple of times. I have noticed only three issues.
- I have noticed that you can enter letters to the input, but the user should be able to enter only number. You can fix it by adding the type arttibute This is an example ob how you can fix it
<input type="text" id="days" class="form-container-input" placeholder="DD" oninput="onInputChange(days.value, event)" type="number">- I have noticed that when you hover on the button it doesn't make the cursor a pointer so the user don't know where to press. You can add the cursor property to the CSS
- I think you should replace the form-container div to a form Other than that your project is great
Marked as helpful - @m1mmseen@Bashamega
Hello:) It looks great. I think that you should use desktop divider on the desktop version
