shahidAfrid1• 350
@shahidAfrid1
Submitted
please, give me feedback on the responsive part.
Batool H.
@BatoolHasan
All comments
- Batool H.• 320
@BatoolHasan
Posted
great job on the challenge! I noticed on a desktop screen larger than 1440px, the background does not stretch. Make sure to set the background-size property to "contain" so it would fit any screen.
Marked as helpful
0 - Adam Phillips• 115
@adphillips2017
Submitted
I'm not super happy with the smallest version of the responsive design, any tips / feedback would be great.
Batool H.• 320@BatoolHasan
Posted
Thank you for your submission! I learned a lot from it, especially the trick to the background of the slider.
Some improvements would be to decrease the headings font size on the smallest version, and note that in the smallest version the heading 'Sign-up for our 30-day trial. No credit card required.' actually ends up separating the two sentences over two lines.
One other improvement would be to remove the default border CSS applies to button elements. As for the input type of range, make sure to add a title attribute to fix the accessibility issue.
1
