Skip to content
OverviewSolutions
18
Comments
375

Ahmed Bayoumi

@Bayoumi-devCairo6,680 points

Creative Solutions Front-End Web developer, I am creating attractive and responsive website designs for a more interesting and flexible user experience.

Latest solutions

View more solutions

Latest comments

  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey Tadem, Congratulations on completing this challenge... You have accessibility issues that need to fix.

    • Document should have one main landmark, Contain the component with <main>.
    <main>
   <div class="container">
      //...
   </div>
</main>

    • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

    • All page content should be contained by landmarks, Contain the attribution with <footer>.

    <footer>
   <div class="attribution">
      //...
   </div>
</footer>

    Hope this help!... Keep coding👍

  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey Sujeong, It looks good!... Here are some suggestions:

    • Document should have one main landmark, Contain the component with <main>.
    <main>
   <div class="card">
      //...
   </div>
</main>
    • Use <a> to wrap Equilibrium #3429 and Jules Wyvern, then add cursor: pointer; to the <a>, The cursor indicates to users there is an action that will be executed when clicking on it.

    Equilibrium #3429 ---> Navigate the user to another page to see the NFT

    Jules Wyvern ---> Navigate the user to another page to see the creator's portfolio

    • To do the active state for the image on the NFT preview card I suggest you wrap the image of the NFT with the img-wrapper element and create another element to make it overlay on the image, it contains the view icon.
    <div class="img-wrapper">
      <img class="card-img" src="images/image-equilibrium.jpg" alt="Image Equilibrium">
      <div class="overlay"><img src="images/icon-view.svg" alt=""></div>
</div>

    Then add the following styles:

    .img-wrapper {
  width: ...;  /* it's up to you */
  height: ...;  /* it's up to you */
  position: relative; /*To flow the child element on it*/
  cursor: pointer;
  overflow: hidden;
}
.img-wrapper .card-img{
  width: 100%;
  height: 100%;
}
.overlay {
  background-color: hsla(178, 100%, 50%, 0.5);
  display: flex;       /* Center the view icon with flexbox*/
  align-items: center;
  justify-content: center;
  position: absolute;
  top: 0;
  width: 100%;
  height: 100%;
  opacity: 0;
}
.img-wrapper:hover .overlay {
  opacity: 1;
}

    There is another way to do the active state for the image on the NFT preview card by creating pseudo-elements (::after, ::before) to use one as an overlay and other for view-icon.

    Resources

    Hope this is helpful to you... Keep coding👍

    Marked as helpful
  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey! It looks good!... You have accessibility issues that need to fix.

    • Document should have one main landmark, Contain the component with <main>.
    <main>
   <div class="container">
      //...
   </div>
</main>

    • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

    • All page content should be contained by landmarks, Contain the attribution with <footer>.

    <footer>
   <div class="attribution">
      //...
   </div>
</footer>
    • Buttons must have the discernible text, So don't leave the alt attribute empty when using the image <img> inside the button <button> without text. 
      <button class="change">
     <img src="./images/icon-dice.svg" alt="Advice Generator">
</button>
      Or set the attribute aria-label to describe the button.

    Hope this help!... Keep coding👍

  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey Shehab, It looks good!... You have accessibility issues that need to fix.

    • Documents must have <title> element to aid in navigation
    <head>
   //...
   <title>3-column preview card component | Frontend Mentor</title>
</head>
    • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

    ---> Multiple <h1> elements on one page

    I hope this is helpful to you... Keep coding👍

  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey John, It looks good!... Here are some suggestions:

    • Document should have one main landmark, Contain the component with <main>.
    <main class="container">
   <div class="qr_code_card">
      //...
   </div>
</main>

    • Page should contain a level-one heading, Change <p class="p1"> to <h1 class="heading"> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

    • You have used grid to center the component on the page, but you need to set the height of the container ---> min-height: 100vh; to center it at this height:

    .container {
   display: grid;
    justify-content: center;
    align-items: center;
    /* width: 1440px;        /* <---- Remove  */
    /* height: 800px;         /* <---- Remove  */
    min-height: 100vh;     /* <--- Add */
 }
    • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

    Hope this help!... Keep coding👍

    Marked as helpful
  • Ahmed Bayoumi•6,680
    @Bayoumi-dev

    Hey Brian, It looks great!... Here are some suggestions:

    • Instead round each corner and create media queries to change it based on the screen size, Give the parent these classes rounded, overflow-hidden
    <main class="container rounded overflow-hidden" id="container">
   //...
</main>
    • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

    ---> Multiple <h1> elements on one page

    Hope this help!... Keep coding👍

    Marked as helpful
View more comments