All comments

• 

  Ibrahim-Ghazaly•70

  @Ibrahim-Ghazaly

  Submitted about 3 years ago

  

  Responsive card component using grid

  1

  20
  

  Bazthos•430

  @Bazthos

  Posted about 3 years ago

  Hello @Ibrahim-Ghazaly :)

  I have some suggestion regarding your solution :

  • Use the main landmark to wrap the body content : HTML5 landmark elements used to improve navigation
  • To center your content in viewport, you can use a flexbox display on your body, min-height: 100vh and align-items/justify-content with center value;
  • Related to your font-family in title (h2), the property is clearly defined but it is in comment CSS (just remove /* --- */ and it'll be good)

  Overall your solution is good, keep it up ! Happy coding

  0