All comments

• 

  Felipe• 10

  @felipe-goes

  Submitted over 2 years ago

  Hello everyone. Please feel free to give me any feedbacks. I do not have much experience so I would like to have some tips on the best practices and how to make the page responsive. Thank you all.

  

  HTML5 and CSS3 desktop solution for the Order Summary Page.

  3

  2

  0

  

  Beeching• 45

  @Beeching

  Posted over 2 years ago

  Hey, this is a good first solution, good job!!

  One thing I'm noticing is it looks a lil bit "squished", the main reason being the card-summary <p> line height. Try adjusting the line-height for it in your css, you'd be surprised how much of a difference small things like that can make! I have found that 26px seems to work nicely in your solution.

  One more thing, try to avoid setting the font-size in px. Pixels are considered bad practice for accessibility reasons, it overrides the browsers default settings which can impact people who have adjusted their browsers default font-size. You don't need to overwhelm yourself with all of the different units just yet, but it wont hurt to read about them. What I would suggest to start with is to set your font-sizes in "rem"s rather than "px"s.

  There are a lot of videos on youtube explaining REMs and other relative css units! feel free to check them out when you get some free time. Have a good day, keep it up :)

  Marked as helpful

  0