Looking to hire developers?
@Bhikule19
@4jdin
Submitted
This is my second website I've built and I really put a lot of effort into it.
As with all my work, I would be very grateful if you would leave me some criticism or advice, because that way I can progress more easily. If you have any questions for me, feel free to ask.
@Bhikule19
Posted
Hey, there amazing work,
body {
padding-top: 250px;
font-style: none;
background-size: cover;
background-position: center;
background-color: #f3eae3;
display: flex;
justify-content: center;
align-items: center;
}
body {
min-height: 100vh;
font-style: none;
background-size: cover;
background-position: center;
background-color: #f3eae3;
display: flex;
justify-content: center;
align-items: center;
}
min-height: 100vh;If you found this helpful you can mark this cmt as helpful
Marked as helpful
@johnhaab
Submitted
Feedback appreciated.
Learning JS so its not the best.
@Bhikule19
Posted
Amazing work there, just to let you know the picture tag syntax can be more meaningful as it is used to manipulate img for different screen sizes.
You can take a look at this how you can write picture tag the better way:-
<picture>
<source
media="(max-width: 450px)"
srcset="./images/pattern-divider-mobile.svg"
/>
<img
src="./images/pattern-divider-desktop.svg"
alt="divider pattern svg"
class="divider"
/>
</picture>
I hope you found it useful
Marked as helpful
@danyczech
Submitted
Hi there!
My second task. Any suggestions? I was thinking about putting those images as the background-image, but finally, I let them as part of the HTML and used display: none when needed. I am not sure which solution is better or the best practice.
@Bhikule19
Posted
You can do this alternative method:- So what happening here is, if the screen width is more than 800px it will use the desktop version of the image that you will provide, whereas when the screen comes to less than 780px it will implement the mobile version of that image.
<picture>
<source media="(max-width: 780px)" srcset="mobile-image.jpg" />
<source media="(min-width: 800px)" srcset="desktop-image.jpg" />
<img src="desktop-image.jpg" alt="" />
</picture>
You can visit:- Developer docs by mozilla
If you found this insightful, you can mark this comment as helpful Thank you.
Marked as helpful
@luisdatc
Submitted
Hello guys.
I used grid to solve this challenge but i don't know if was the best choice.
If you think there are another way to solve this challenge let me know.
thank you.
@Bhikule19
Posted
Hey there mate, I really liked the way you used the article tag to implement the title, paragraph, and CTA. An alternate for this will be mainly flexbox. By having two div inside the main element, you can provide them with the class left and right respectively, and by giving the [ display: flex ] property to the main container in which these two reside, you can easily manipulate them. If you found this helpful you can make this comment marked as helpful.
Thank you.
Marked as helpful
@catherineisonline
Submitted
Hello, Frontend Mentor community! This is my solution to the Base Apparel coming soon page.
I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
@Bhikule19
Posted
Hey Catherine, The work is amazing, just so you know the placeholder text did not inherit the font family. So to do the trick, you can do the following:- "input::placeholder { font-family: }" This way you give the font family style to the placeholder text too.
@thefandykid01
Submitted
@Bhikule19
Posted
Hey there, Congratulations on your work. I just looked at your code and got some things to suggest for you as a fresher developer I myself made such mistakes.
Check out this below link for more understanding:- https://www.w3schools.com/tags/tag_del.asp#:~:text=The%20tag%20defines%20text,a%20line%20through%20deleted%20text.
If you find this insightful in any way you can give it marked as helpful.
Marked as helpful
