Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @jvisme1991

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am most proud of completing my first challenge that included using javascript.

    What challenges did you encounter, and how did you overcome them?

    Using js without knowing any of the fundamentals was a nightmare. I will definitely work more with js to gain a better familiarity with it for future use.

    What specific areas of your project would you like help with?

    I would most definitely like more help with js.

    P
    CJ Cameron 350

    @CJCameron13

    Posted

    Nice work! Another approach you could use is the classList.toggle feature to achieve the same functionality that you currently have. I like to add a class called 'hidden' to the element and in my CSS document, given .hidden the attribute of display:none.

    .hidden {
    display: none; 
    }
    

    Using your shareButton and shareLinks identifier, the JS code would look something like this...

    shareButton.addEventListener('click', () => {
    shareLinks.classList.toggle('hidden')
    }
    
    Now the 'hidden" class will toggle on and off with each click by the user.
    
    Just my preferred method. Well done with the project!
    

    Marked as helpful

    0
  • P
    CJ Cameron 350

    @CJCameron13

    Submitted

    Overall very pleased with how this came out. The hamburger menu is purely CSS. The transition from the "X" back to the hamburger is a bit funky, I'd appreciate any suggestions for how to fix that. And of course any feedback on what I could have done better. Thanks!

    P
    CJ Cameron 350

    @CJCameron13

    Posted

    Update: I'm not sure what happened to my menu in the desktop version. I will work on rectifying that.

    0