
Carl
@CarlHummAll solutions
Newsletter Signup Form
#sass/scssPSubmitted 2 months agoI was mostly focused on the HTML/CSS but I feel like the logic in the newsletter form class could be split up and abstracted in a better way, such as creating new functions, sub-classes, etc. At present, there is a lot going on here, and it feels like I am putting everything in main.
Still matching the design and implementing some localState, if anyone spots any differences would appreciate the feedback/advice.
All feedback welcome.
Product Preview Card Component (HTML, CSS)
#sass/scssPSubmitted 6 months agoArticle, div or li?
I used an
h3
in place ofh2
orh1
as I viewed the component as part of a larger real life page, but that's not what confused me.I wasn't sure whether the main card should be an
article
,div
orli
. The card could easily be part of a carousel of li's, it could also be a stand alone div or article, this is where I was confused. In the end I decided to make it an article.Any advice on what tags are most appropriate and what tags I could use for
.product__content
and.product__thumbnail
would be appreciated. These feel like dividing sections/containers to me, and I wasn't sure whether a div or section would be most appropriate.Thanks for reading, open to any advice/tips!