César Mejias• 190
@CesarGMEFA
Submitted
I look forward to your comments 💚
César Mejias
@CesarGMEFA
All comments
- César Mejias• 190
@CesarGMEFA
Posted
I will adjust the size of various elements
0 - Matí Abarca• 20
@matias-user
Submitted
greetings dear community
César Mejias• 190@CesarGMEFA
Posted
I'm doing another job and the selectButton.js code was very helpful, thank you
0 - Lukas• 340
@LucaTwentySeven
Submitted
I think I can shrink my code at least about 20%. What do you think?
César Mejias• 190@CesarGMEFA
Posted
Good job, this is a challenge that I have not yet started. I would like to know what JavaScript is needed?
I want to know after doing it. If you want you can review my work so that later you can do it.
0 - Victoria Cheng• 320
@victoriacheng15
Submitted
feedback is always welcome and appreciated.
César Mejias• 190@CesarGMEFA
Posted
I think my screen is 1366px and the view I receive from your page is this. https://prnt.sc/26b794j and this https://prnt.sc/26b79cv then it gives me the impression that it is not ok.
But when I test the responsive from the element inspector everything seems to be fine. Look https://prnt.sc/26b7ac9
0 - Victoria Cheng• 320
@victoriacheng15
Submitted
feedback is always welcome and appreciated.
César Mejias• 190@CesarGMEFA
Posted
Hi bro, from my 14-inch laptop your page does not see well :(
0 - ouuoussama• 30
@ouuoussama
Submitted
i want your opinions
César Mejias• 190@CesarGMEFA
Posted
You could accommodate the paragraphs of the buyers' comments, putting a (font-size: 15px;) and (line-height: 21px;) and in the list of styles it says that the font size should be 15px.
0 - Juan Hamilton• 470
@hamilton-i7
Submitted
This is my first challenge using React. Any constructive feedback is welcome
César Mejias• 190@CesarGMEFA
Posted
I do not understand that. Could you explain me please
0 - prakash• 250
@mewebbie
Submitted
Feedbacks are most welcome.
César Mejias• 190@CesarGMEFA
Posted
Hi! I want to tell you that you can apply this to the rem measure. html { font-size: 62.5%; } In this way 1rem would be the same at 10px. so 1.8rem is 18px, 3rem is 30px.
the size of the browser is 16px and if you pass that code it is 10px.
0 - Jakob Lewis• 20
@Jakeyikapp
Submitted
Please let me know if there is anyway I can structure my HTML or CSS better or if there are any better ways to code this challenge.
César Mejias• 190@CesarGMEFA
Posted
Good sibling code, you could place the .attribution inside the main so that it doesn't overflow on top of the card and add a margin-top to it. For instance.
The other thing is that you can put a link to your name in the attribution.
The other thing you could accommodate is the width in the .card-container in the @media. It's at 330px and the size of an iphone 5 would be 320px, so it looks weird.
I do those things and send you the proposed changes on github. and check the size of the box because in the body you put a height of 100vh and it still produces a horizontal scroll.
Marked as helpful
1
