@vincentferraro
Submitted
Hello, My second challenges :) I use px and % for set the size. What's the best practice please? i've add responsive rules, if you have advices i appreciate. Thank you Vincent
Looking to hire developers?
@Chris94Lee
@vincentferraro
Submitted
Hello, My second challenges :) I use px and % for set the size. What's the best practice please? i've add responsive rules, if you have advices i appreciate. Thank you Vincent
@Chris94Lee
Posted
Hey Vincent, looking good!
One thing I noticed is that you're missing a background colour.
What I'd do is add background-color: #E0E8FF
to your body
in the CSS file.
Also, to make the background image fit like the designs, you can add background-repeat: repeat-x;
and then remove the background-size
style you have on the body. Let me know if this works for you!
Also regarding px for size, I try to avoid pixels for accessibility reasons, and tend to stick to either em or rem. Check out: https://engageinteractive.co.uk/blog/em-vs-rem-vs-px
Looking forward to seeing your future work!
@devansh-ios
Submitted
if you do the preview website the page is showing fine but i think there is some problem in my code because of that it is showing the three container stacking on over each other , feel free to give any suggestion .
@Chris94Lee
Posted
Hey Devansh,
I believe the reason why it's showing the mobile design in the preview, is because of your media query: @media (min-width:375px) and (max-width:1440px)
. So here you're using the 3 stacked containers on screen devices between 375px and 1440px. I'd recommend having the max-width as 1000px. And also to remove the min-width, because on devices smaller than 375px, it's reverting back to the web layout.
If i'm incorrect here then someone else feel free to correct me.