Darren• 30
@Darren52BT
Submitted
P
CodingTube
@CodinGitHub
All comments
- PCodingTube• 510
@CodinGitHub
Posted
Nice solution! Perhaps I could suggest reserving the h1 tag for an entire section. In this case, since it's a card, you could use h2...h6 tags instead.
Using a naming methodology like BEM to give names to classes can also help you maintain your code readability.
Marked as helpful
0 - Chris• 130
@Cortele
Submitted
PCodingTube• 510@CodinGitHub
Posted
Hi! Great solution! Just one thing I'd like to point out: the style tag is not necessary if you have a stylesheet. I recommend removing it and placing the styles from this tag into the styles.css file. This approach will keep your code cleaner and more organized. Happy coding!
Marked as helpful
1 - PCodingTube• 510
@CodinGitHub
Submitted
Simple product card using HTML and CSS Any feedback is welcome!
PCodingTube• 510@CodinGitHub
Posted
Thank you very much for your feedback! I decide to use margin to every single element because if I use padding in the card container the image doesn't fit to the 100% of the width of the card and I don't like to use position absolute to do that. Do you know another way to achieve the image use all the width of the container even if the container have a padding?
1 - PCodingTube• 510
@CodinGitHub
Submitted
Any feedbak is wellcome 😊
PCodingTube• 510@CodinGitHub
Posted
Hi Vanza thank you very much for your feedback. I really appreciate it. This will help me improve my developer's skill a lot.
0 - PCodingTube• 510
@CodinGitHub
Submitted
I enjoyed this challenge a lot. Please, any feedback is welcome.
PCodingTube• 510@CodinGitHub
Posted
Hi! thank you very much for the feedback
1 - Niti Mittal• 260
@NitiMittal
Submitted
Feedbacks and suggestions are welcomed.
PCodingTube• 510@CodinGitHub
Posted
Good Job! I see that you're using variables in CSS. That's a good practice. 👏👏👏
0
