All comments

• 

  zamouni• 20

  @zamouni

  Submitted over 1 year ago

  

  Qr code

  4

  4

  0

  

  Cyclone3603• 90

  @Cyclone3603

  Posted over 1 year ago

  When styling elements, it's best to keep all the stylings in one place. Either a style tag or a style.css document is fine. Generally try to avoid in-line stylings though, as it can make restyling objects in your code more tedious when you have bigger projects.

  For the image, you have to link the file locally. Try using <img src="image-qr-code.png" width="195px" height="190px" alt="image-qr-code" class="QR"> and it should work.

  Also make sure to change the font to the correct one, as opposed to the default serif font.

  Marked as helpful

  0
• 

  Catherine V• 30

  @Catherine1998

  Submitted over 1 year ago

  I found difficult the styles like pading, margins, and that, but I learned a lot.

  A little bit of the background that the svg image looked good on mobile

  is okey if I write comments in the code?

  

  First Challenge Fronted with CSS and HTML using hover and nth-child

  2

  1

  0

  

  Cyclone3603• 90

  @Cyclone3603

  Posted over 1 year ago

  This looks really cool! But maybe next time, you can add a transition time to your hover effects to make it look smoother. For example:

  button{
    border: none;
    border-radius: 10px;
    background-color: purple;
    color: white;
    transition: 200ms;
  }
  
  button:hover{
    background-color: lilac;
  }
  

  This should make the change from a darker color to a lighter color less jarring, and have it fade in.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Derek Lartey• 110

  @DerekLartey

  Submitted over 1 year ago

  This is the third time I'm submitting this project. The first two I made weren't responsive. Learned my mistakes with the help of a good friend and some research. Glad to have it done now!

  

  QR - Code

  2

  2

  0

  

  Cyclone3603• 90

  @Cyclone3603

  Posted over 1 year ago

  I really like your solution! Seems a bit bigger than the original though. I set the width of mine to around 250px. That set the height to be closer to the original, maybe try something in that range?

  I also just wanted to ask how you got your site up? I've been trying (and failing) to do so for the past 3 days.

  Marked as helpful

  0

  This comment has received 1 replyShow