P
@toshirokubota
What specific areas of your project would you like help with?
Any suggestions on improving the code and styles are highly appreciated!
DILHT
@DILHTAll comments
- @DILHT
the page is responsive and the css is clean and i have admired the way you have used your grid skills. great work
- P@kephaloskWhat are you most proud of, and what would you do differently next time?
First Time I worked with CSS Grid in that dimension.
What challenges did you encounter, and how did you overcome them?Creating the complex Layout by using CSS Grid.
What specific areas of your project would you like help with?n/a
@DILHTi like how you have make your css soo clean and responsive. great work
Marked as helpful - @amir-mirzakhaniWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
@DILHTThe solution is solid and demonstrates thoughtful implementation. i just like the idea that the code is not alot. that the page is big enough and responsive too.keep up the good work
- @lucasribeirosantos@DILHT
The layout is responsive and visually consistent across screen sizes and i love the way you have organized your files.Keep up the good work
Marked as helpful - @alaa-mekibes@DILHT
The responsive design principles are well-considered with media queries for smaller screens and The solution effectively uses semantic HTML elements like <main>, <section>, <ul>, <ol>, and <table>, enhancing both accessibility and structure. Good Job !!!
- P@RetroApeWhat are you most proud of, and what would you do differently next time?
Managing to use
What challenges did you encounter, and how did you overcome them?flexboxlayout; my attainment rises...Had some trouble at the start; I tried to over-engineer the solution. Layout was breaking and there were too many variables. I took a step back and found it easier to use
flex-endandgapto solve my problem.Also, trying to match the design without a design file is much harder than having a Figma file.
What specific areas of your project would you like help with?Using
flexbox; how would one center the main object (card) horizontally and vertically (without.attributionaffecting the alignment), and still have.attributionbe right below that main object, without usingpositionon the.attribution?@DILHTthe code is well written, and the design is much better than me :-).About the issue of centering the main object(card) horizontally and vertically. you could have put both card and the attribution in the flex container and use flex-direction column and yes, I have seen it in the code this was going to stack them vertically. Good Work Tomislav
Marked as helpful - @BoffdubWhat are you most proud of, and what would you do differently next time?
I feel like I'm getting better after every time I do this.
What challenges did you encounter, and how did you overcome them?I initially had issues with centering the image. I manage to get help on the discord and a few people had the answer I was looking for.
I also had issues with the caption bar but I managed to figure that out on my own.
What specific areas of your project would you like help with?If there is a way to have a cleaner CSS page, that would be appreciated.
@DILHTGreat job on the design! To take it to the next level, consider adding interactive states to your <h1> and using HTML5 semantic elements like <header>, <main>, and <footer> improve code structure and accessibility. also check out media queries for responsiveness . Keep up the good work and keep learning!
Marked as helpful - @CamrynTidsworthWhat are you most proud of, and what would you do differently next time?
This project was a great opportunity to get comfortable using GitHub. Next time, I'd like to focus on creating more reusable variables for my CSS style components like font size, color, etc.
What challenges did you encounter, and how did you overcome them?I struggled a bit with positioning the QR code. Ultimately, I realized that you can't use flexbox for everything (only most things ; ) ), and used plain old positioning properties to solve the problem.
What specific areas of your project would you like help with?I noticed that the lines of text in my design are slightly off compared to the example. I'm not sure how much of an issue this is but if anyone has a take on whether it's important/how to tweak it I'm very open to feedback.
@DILHTThe HTML structure is well-organized, and you've used semantic elements like div with descriptive classes, which is great. However, you could further improve the semantic meaning by using more specific HTML5 elements, such as header, main, and footer, instead of generic div elements.All things considered the code is well organised
