Skip to content
OverviewSolutions
6
Comments
4
Dan
@Daniel3-14

All comments

  • Dan•90
    @Daniel3-14

    Hi! I think this looks good!

    I might just be being overly picky, but I feel like the gap in between the boxes should be static, and not be growing with the screen size. It is a little off-putting, and in this particular circumstance, it starts to look like 4 distinct columns that you might assume have related data, but they don't.

    (i.e. The two smaller boxes under the big Facebook box have information for Facebook and Twitter)

    Adding a static sized gap between the cards, maybe increasing the card max-width (or perhaps not having one at all?) and maybe decreasing the 'main' max-width just a bit are my suggestions.

    Good job! Hope this helps!

    Marked as helpful
  • Dan•90
    @Daniel3-14

    Wow, the fact that you can assign new colors to the existing variables in a .dark-mode class makes my solution seem wayyy more complicated than it needs to be. I did a whole bunch of needless stuff in javascript for dark mode.

    Good job! I'm glad I saw this and learned something useful.

  • Dan•90
    @Daniel3-14

    I'm pretty new so I might not know what I'm talking about, but I found your use of JavaScript on this one to be crazy short and awesome. It's a whole different design approach that I don't think I would have thought about myself. I'm glad I saw this!

    Apparently a quick compliment is flagged as too short of a comment on this website, so I'm adding some useless words here.

  • Dan•90
    @Daniel3-14

    I think the design could use a little work. Just tiny little things like margin/padding/line height. Also, the ratings don't have any hover effect.

    Other than that, I think this is great Derrick! I'm glad I stumbled across it, because I was having trouble rendering a 'Thank You' page on my project using pure js, but after seeing your solution it seems so easy!

    Also, your README is great! I feel like a lot of people, myself included, are too lazy/too focused on the main task to actually get that part done.